Petr Horáček has posted comments on this change.

Change subject: net: Consume ifcfg files that have a non vdsm standard name
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/63990/1//COMMIT_MSG
Commit Message:

Line 12: If the host is set initially by Network Manager, the names of the files
Line 13: do no correspond to the expected format.
Line 14: 
Line 15: This patch adjusts the ifcfg file name to the mentioned format and
Line 16: erases any other ifcfg files that correspond to the same device.
that is not really NM friendly. it is valid to have multiple configurations per 
on iface, even without NM. is there PRIORITY parameter available for ifcfg 
files? if there is, won't be better to set big big big number as priority for 
VDSM ifcfg files?
Line 17: 
Line 18: Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Line 19: TODO: Add functional tests.


-- 
To view, visit https://gerrit.ovirt.org/63990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to