Petr Horáček has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name ......................................................................
Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/63990/4/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 236: DynamicSourceRoute.addInterfaceTracking(netEnt) Line 237: Line 238: def removeBond(self, bonding): Line 239: if not self.owned_device(bonding.name): Line 240: self.normalize_device_filename(bonding.name) > As far as I know, network caps is generated from actual kernel settings, an For networks I guess it would be somehow 'emergency' removed. Not sure about bonds. I can't imagine a situation where would the additional check hurt. Line 241: to_be_removed = self._ifaceDownAndCleanup(bonding) Line 242: if to_be_removed: Line 243: self.configApplier.removeBonding(bonding.name) Line 244: if bonding.on_removal_just_detach_from_network: -- To view, visit https://gerrit.ovirt.org/63990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman <mbur...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
