Yaniv Bronhaim has posted comments on this change.
Change subject: Adding system information to getCapabilities
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/caps.py
Line 248:
Line 249:
Line 250: def __getDmidecodeData(whatdata):
Line 251: # dmidecode commands must run as root (sude=True)
Line 252: ret, out, err = execCmd([constants.EXT_DMIDECODE, '-s',
whatdata], True)
Don't you prefer that way instead of adding another package dependency? It's
only 6 values that we get by 6 sudo commands, instead of loading another
package and adding to supervdsm another api function that returns those values
by import this package and arrange outputs... For me it looked too much for
that, so I decided to get those values that way.
Line 253: if err:
Line 254: raise OSError("Error while collecting system info: %s", err)
Line 255: return out[0]
Line 256:
--
To view, visit http://gerrit.ovirt.org/9258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
