ShaoHe Feng has posted comments on this change.
Change subject: Adding system information to getCapabilities
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 852: # @hostSerialNumber Hardware serial number
Line 853: #
Line 854: # @hostFamily Processor type
Line 855: #
Line 856: # @hostUUID Host's hardware UUID
a tab?
Line 857: #
Line 858: # @hostVersion Host's hardware version
Line 859: #
Line 860: # @cpuCores: The number of CPU cores present
Line 917: # Notes: Since ovirt-engine cannot parse software versions in 'x.y.z'
format,
Line 918: # the current API truncates @software_version to 'x.y'.
Line 919: ##
Line 920: {'type': 'VdsmCapabilities',
Line 921: 'data': {'kvmEnabled': 'bool', 'hostManufucturer': 'str',
hostManufacturer?
Line 922: 'hostProductName': 'str', 'hostVersion': 'str',
Line 923: 'hostSerialNumber': 'str', 'hostUUID': 'str',
Line 924: 'hostFamily': 'str', 'cpuCores': 'uint',
Line 925: 'cpuSockets': 'uint', 'cpuSpeed': 'float', 'cpuModel':
'str',
--
To view, visit http://gerrit.ovirt.org/9258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
