Yaniv Bronhaim has posted comments on this change.
Change subject: Adding system information to getCapabilities
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File vdsm/caps.py
Line 264:
Line 265: cpuInfo = CpuInfo()
Line 266: cpuTopology = CpuTopology()
Line 267:
Line 268: caps['hostManufacturer'] =
__getDmidecodeData("system-manufacturer")
why? dmidecode util does the same and more when you retrieve this information
Line 269: caps['hostProductName'] =
__getDmidecodeData("system-product-name")
Line 270: caps['hostVersion'] = __getDmidecodeData("system-version")
Line 271: caps['hostSerialNumber'] =
__getDmidecodeData("system-serial-number")
Line 272: caps['hostUUID'] = __getDmidecodeData("system-uuid")
....................................................
File vdsm/constants.py.in
Line 147: EXT_VDSM_STORE_NET_CONFIG = '@VDSMDIR@/vdsm-store-net-config'
Line 148:
Line 149: EXT_WGET = '@WGET_PATH@'
Line 150: EXT_WRITE_NET_CONFIG = '@VDSMDIR@/write-net-config'
Line 151: EXT_DMIDECODE = '@DMIDECODE_PATH@'
Look on previous patch' comments.. I don't have good reason to work with
dmidecode-python, it adds dependency and it returns the same data and a lot
more that we don't need. Additionally It requires to add another svdsm api and
another file that works with this dmidecode util... do you prefer that way?? It
was hard to decide.
And what is so wrong with constants file? It looks normal to me ..
Line 152:
Line 153: CMD_LOWPRIO = [EXT_NICE, '-n', '19', EXT_IONICE, '-c', '3']
Line 154:
Line 155: #
--
To view, visit http://gerrit.ovirt.org/9258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
