Michal Skrivanek has posted comments on this change. Change subject: virt: Initial support for post-copy migration ......................................................................
Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 480: self._compressed else 0) | Line 481: (libvirt.VIR_MIGRATE_AUTO_CONVERGE if Line 482: self._autoConverge else 0)) Line 483: if self._use_convergence_schedule: Line 484: # TODO: Replace this whole block with simple flag setting once > Do we care about non-RHEL/CentOS systems (e.g. Fedora)? sure we do, but those are using upstream qemu-kvm which has it already Line 485: # Vdsm depends on proper versions of QEMU and libvirt. Line 486: try: Line 487: flags |= libvirt.VIR_MIGRATE_POSTCOPY Line 488: except AttributeError: Line 490: pass Line 491: # There is a QEMU bug causing post-copy migration fail when Line 492: # (XBZRLE) compression is enabled. So let's disable the Line 493: # compression until we depend on a fixed QEMU version. Line 494: # See https://bugzilla.redhat.com/1368422. > So are we "never" going to use compression with post-copy? for now, correct. So we won't include it in any profile. Later on once it works we people can enable it without any vdsm change Line 495: if flags & libvirt.VIR_MIGRATE_POSTCOPY: Line 496: flags &= ~libvirt.VIR_MIGRATE_COMPRESSED Line 497: self._vm._dom.migrateToURI3(duri, params, flags) Line 498: else: Line 827: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_PROCESSED], Line 828: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_REMAINING], Line 829: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_BPS], Line 830: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_CONSTANT], Line 831: stats.get(libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES, 0), > When compression is disabled (at least with post-copy enabled), this item i hm, isn't it a bug then? can you please onfirm, i would expect it's 0 when compression is diabled regardless pre or post opy Line 832: # available since libvirt 1.3 Line 833: stats.get('memory_dirty_rate', -1), Line 834: # available since libvirt 1.3 Line 835: stats.get('memory_iteration', -1), -- To view, visit https://gerrit.ovirt.org/62873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
