Francesco Romani has posted comments on this change. Change subject: virt: Initial support for post-copy migration ......................................................................
Patch Set 8: (3 comments) partial review https://gerrit.ovirt.org/#/c/62873/8/vdsm.spec.in File vdsm.spec.in: Line 187: Requires: libvirt-daemon-kvm >= 1.3.5 Line 188: %else # rhel Line 189: Requires: libvirt-daemon-kvm >= 1.3.3 Line 190: Requires: libvirt-python >= 1.3.4 Line 191: %endif ok, this may need to be split in a separate change, depending on the time of availability of the packages Line 192: Line 193: # iscsi-intiator versions Line 194: %if 0%{?rhel} Line 195: Requires: iscsi-initiator-utils https://gerrit.ovirt.org/#/c/62873/8/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 478 Line 479 Line 480 Line 481 Line 482 unrelated, please drop this change if you resubmit PS8, Line 778: if self._vm._dom.migrateStartPostCopy(0) < 0: ugh, this reads so C-ish :) I'd prefer to use this idiom: ret = self._vm.dom.migrateStartPostCopy(0) if ret < 0: #... but this is mostly taste and personal preference, so I'll not press much for this. -- To view, visit https://gerrit.ovirt.org/62873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
