Michal Skrivanek has posted comments on this change. Change subject: virt: Initial support for post-copy migration ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 827: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_PROCESSED], Line 828: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_REMAINING], Line 829: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_BPS], Line 830: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_CONSTANT], Line 831: stats.get(libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES, 0), > Documentation doesn't say under what circumstances the attribute is present thanks, then that patch has quite a priority since for legacy profiles we do not use compression, and since https://gerrit.ovirt.org/#/c/64178/ we do not enable it either for the default profile Line 832: # available since libvirt 1.3 Line 833: stats.get('memory_dirty_rate', -1), Line 834: # available since libvirt 1.3 Line 835: stats.get('memory_iteration', -1), -- To view, visit https://gerrit.ovirt.org/62873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org