Zhou Zheng Sheng has posted comments on this change. Change subject: testRegeneration of remoteFileHandler fails when running all tests ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File tests/remoteFileHandlerTests.py Line 51: the requests""" Line 52: for i in range(HANDLERS_NUM * 2): Line 53: self.testTimeout() Line 54: for i in range(HANDLERS_NUM): Line 55: self.testEcho() From the code, I can see RemoteFileHandlerPool.callCrabRPCFunction() always enumerates from index 0. The lock and release behaviour on the handler are for concurrent calls. In testRegeneration() it does just sequential calls. That means testRegeneration() always use the remote handler in index 0. In RemoteFileHandlerPool.callCrabRPCFunction(), when it except Timeout, it kills the remote process and set self.handlers[i] to None. That means when that handler is to be used the next time, a new process will always be generated so there is no chance to issue a request to a stuck handler. So I have no idea how testEcho() can raise Timeout exception here, since it runs on a fresh remote handler. I can not reproduce the error. Could you explain more of it? P.S. I think the problem is not in the way of using RemoteFileHandlerPool as above. If we detects Timemout from RemoteFileHandlerPool in the above case, the problem maybe in either RemoteFileHandlerPool or the target remote function. We should fix those, not the test. Line 56: Line 57: def tearDown(self): Line 58: self.pool.close() Line 59: -- To view, visit http://gerrit.ovirt.org/9412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ae1258d01455ad2fe131cd17bc3dff89224c1b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
