Yaniv Bronhaim has posted comments on this change. Change subject: testRegeneration of remoteFileHandler fails when running all tests ......................................................................
Patch Set 1: (1 inline comment) .................................................... File tests/remoteFileHandlerTests.py Line 51: the requests""" Line 52: for i in range(HANDLERS_NUM * 2): Line 53: self.testTimeout() Line 54: for i in range(HANDLERS_NUM): Line 55: self.testEcho() Mmmm I missed something.. We want to create new poolHandler instance only if timeout was raised, that can say that the handler is stuck and we need to create another one. So isn't it enough to run testTimeout and check if the handler's spot is 'None' afterwards? Line 56: Line 57: def tearDown(self): Line 58: self.pool.close() Line 59: -- To view, visit http://gerrit.ovirt.org/9412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ae1258d01455ad2fe131cd17bc3dff89224c1b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
