Yaniv Bronhaim has posted comments on this change. Change subject: testRegeneration of remoteFileHandler fails when running all tests ......................................................................
Patch Set 1: (1 inline comment) .................................................... File tests/remoteFileHandlerTests.py Line 51: the requests""" Line 52: for i in range(HANDLERS_NUM * 2): Line 53: self.testTimeout() Line 54: for i in range(HANDLERS_NUM): Line 55: self.testEcho() Ok. You are perfectly right... My mistake. All those operations are synchronized and the only used handler is the first one. We need to run more than HANDLERS_NUM ''threads'' that call to crabRpcFunction and see that we free old handlers. Im not sure about what the test was meant to check... but apparently it fails over rhel 6.3 when you run 'make check'. BUT (There is a great but).. when I update it to run the crabCalls simultaneously , it checks the right thing and I found that we don't release the handler after the call has done. No 'None' assignment.. except when timeout is raised.. interesting :0 Do you think that I miss something? Thanks. Line 56: Line 57: def tearDown(self): Line 58: self.pool.close() Line 59: -- To view, visit http://gerrit.ovirt.org/9412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ae1258d01455ad2fe131cd17bc3dff89224c1b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
