Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: use default libvirt event handler impl
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
Thanks Vinzenz for picking this up!
....................................................
File vdsm/libvirtconnection.py
Line 160: for name in dir(libvirt.virConnect):
Line 161: method = getattr(conn, name)
Line 162: if callable(method) and name[0] != '_':
Line 163: setattr(conn, name, wrapMethod(method))
Line 164: conn.setKeepAlive(interval=5, count=3)
I have a vague memory that this may lead to troubles on an over-congested host.
Where are these numbers come from? Why are they good for us?
Line 165:
....................................................
File vdsm/libvirtvm.py
Line 51: DRIVE_NOT_FOUND = "Drive Not Found"
Line 52: BASE_NOT_FOUND = "Base Not Found"
Line 53:
Line 54:
Line 55: EVENT_STRINGS = ("Defined",
I think these can be kept _PRIVATE.
Line 56: "Undefined",
Line 57: "Started",
Line 58: "Suspended",
Line 59: "Resumed",
Line 61: "Shutdown",
Line 62: "PM-Suspended")
Line 63:
Line 64:
Line 65: def event_to_string(event):
Python actually prefers camelCase
Line 66: return EVENT_STRINGS[event]
Line 67:
Line 68:
Line 69: class VmStatsThread(utils.AdvancedStatsThread):
--
To view, visit http://gerrit.ovirt.org/5015
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I735d6b1f856b5a5b216d2dddf629c5ec80e8b7e7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
