Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: use default libvirt event handler impl
......................................................................
Patch Set 3: (5 inline comments)
....................................................
Commit Message
Line 9: Removed libvirtev in favour of the native libvirt event loop
Line 10: implementation. Added setKeepAlive to keep the connection to
Line 11: qemu alive.
Line 12:
Line 13: Moved eventToString from libvirtev.py to libvirtvm.
Done
Line 14:
Line 15: Change-Id: I735d6b1f856b5a5b216d2dddf629c5ec80e8b7e7
....................................................
File vdsm/libvirtconnection.py
Line 160: for name in dir(libvirt.virConnect):
Line 161: method = getattr(conn, name)
Line 162: if callable(method) and name[0] != '_':
Line 163: setattr(conn, name, wrapMethod(method))
Line 164: conn.setKeepAlive(interval=5, count=3)
This comes from the previous patch set. I made them just named parameters. I
personally do not have any experience with it, if it is good or not. We can
leave it out for now and in case of an concurrence of this 'the buggy
condition', which Royce was referring to, experiment with it to see if it helps
anything.
Line 165:
....................................................
File vdsm/libvirtvm.py
Line 51: DRIVE_NOT_FOUND = "Drive Not Found"
Line 52: BASE_NOT_FOUND = "Base Not Found"
Line 53:
Line 54:
Line 55: EVENT_STRINGS = ("Defined",
Done
Line 56: "Undefined",
Line 57: "Started",
Line 58: "Suspended",
Line 59: "Resumed",
Line 58: "Suspended",
Line 59: "Resumed",
Line 60: "Stopped",
Line 61: "Shutdown",
Line 62: "PM-Suspended")
I have adjusted the changelog accordingly.
And added a comment where these values come from.
http://libvirt.org/html/libvirt-libvirt.html#virDomainEventType
Line 63:
Line 64:
Line 65: def event_to_string(event):
Line 66: return EVENT_STRINGS[event]
Line 61: "Shutdown",
Line 62: "PM-Suspended")
Line 63:
Line 64:
Line 65: def event_to_string(event):
I beg to disagree: http://www.python.org/dev/peps/pep-0008/#function-names
Line 66: return EVENT_STRINGS[event]
Line 67:
Line 68:
Line 69: class VmStatsThread(utils.AdvancedStatsThread):
--
To view, visit http://gerrit.ovirt.org/5015
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I735d6b1f856b5a5b216d2dddf629c5ec80e8b7e7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
