ShaoHe Feng has posted comments on this change.
Change subject: vdsm: use default libvirt event handler impl
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
Commit Message
Line 9: Removed libvirtev in favour of the native libvirt event loop
Line 10: implementation. Added setKeepAlive to keep the connection to
Line 11: qemu alive.
Line 12:
Line 13: Moved eventToString from libvirtev.py to libvirtvm.
yes, you have move it to libvirtvm.
but you have some items in eventToString
Line 14:
Line 15: Change-Id: I735d6b1f856b5a5b216d2dddf629c5ec80e8b7e7
....................................................
File vdsm/libvirtvm.py
Line 58: "Suspended",
Line 59: "Resumed",
Line 60: "Stopped",
Line 61: "Shutdown",
Line 62: "PM-Suspended")
in vdsm/libvirtev.py
eventStrings = ("Added",
"Removed",
"Started",
"Suspended",
"Resumed",
"Stopped",
"Saved",
"Restored")
here it is some differences.
so any comment about this?
Line 63:
Line 64:
Line 65: def event_to_string(event):
Line 66: return EVENT_STRINGS[event]
--
To view, visit http://gerrit.ovirt.org/5015
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I735d6b1f856b5a5b216d2dddf629c5ec80e8b7e7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
