Mark Wu has posted comments on this change.
Change subject: Fix duplicate emulated machines returned
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File tests/capsTests.py
Line 63:
Line 64: def testEmulatedMachines(self):
Line 65: testPath = os.path.realpath(__file__)
Line 66: dirName = os.path.split(testPath)[0]
Line 67: path = os.path.join(dirName, "caps_libvirt.out")
Ok, I will update it in next patch.
Line 68: machines = caps._getEmulatedMachines(file(path).read())
Line 69: expectedMachines = ['rhel6.3.0', 'pc', 'rhel6.2.0',
'rhel6.1.0',
Line 70: 'rhel6.0.0', 'rhel5.5.0', 'rhel5.4.4',
'rhel5.4.0']
Line 71: self.assertEqual(machines, expectedMachines)
....................................................
File vdsm/caps.py
Line 130: if capabilities is None:
Line 131: capabilities = _getCapsXMLStr()
Line 132: caps = ET.fromstring(capabilities)
Line 133: return [m.text for m in
Line 134: caps.findall("guest/arch[@name='x86_64']/machine")]
xml.etree.ElementTree is included in python standard library, is it still a
problem?
the way you suggested could become inaccurate.
Line 135:
Line 136:
Line 137: def _getAllCpuModels():
Line 138: cpu_map = minidom.parseString(
--
To view, visit http://gerrit.ovirt.org/8208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e28688bf09b5bc413afffe9cc1501d4247d67e0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
