Dan Kenigsberg has posted comments on this change.
Change subject: Fix duplicate emulated machines returned
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/caps.py
Line 130: if capabilities is None:
Line 131: capabilities = _getCapsXMLStr()
Line 132: caps = xml.etree.ElementTree.fromstring(capabilities)
Line 133: return [m.text for m in
Line 134: caps.findall("guest/arch[@name='x86_64']/machine")]
welcom, xpath, to vdsm.
(I'm slightly hurt by needing to link with both xml.minidom and xml.etree.
maybe we should have a gradual move to etree?)
Line 135:
Line 136:
Line 137: def _getAllCpuModels():
Line 138: cpu_map = minidom.parseString(
--
To view, visit http://gerrit.ovirt.org/8208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e28688bf09b5bc413afffe9cc1501d4247d67e0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
