Adam Litke has posted comments on this change. Change subject: Fix duplicate emulated machines returned ......................................................................
Patch Set 4: I would prefer that you didn't submit this (1 inline comment) Just want to consider if we can avoid importing xml.etree. .................................................... File vdsm/caps.py Line 21: """Collect host capabilities""" Line 22: Line 23: import os Line 24: from xml.dom import minidom Line 25: import xml.etree.ElementTree this is the first time we are using xml.etree. Can you try to change your code so that it only depends on xml.dom.minidom? Line 26: import logging Line 27: import time Line 28: import struct Line 29: import socket -- To view, visit http://gerrit.ovirt.org/8208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e28688bf09b5bc413afffe9cc1501d4247d67e0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
