Igor Lvovsky has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. ......................................................................
Patch Set 7: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm_cli/vdsClient.py Line 1740: 'libvirt-like format. see ' Line 1741: 'http://libvirt.org/formatdomain.html' Line 1742: '#elementsCPUTuning' Line 1743: )), Line 1744: 'vmUpdateDevice': (serv.vmUpdateDevice, You should decide this is updateVmDevice or vmUpdateDevice :) Line 1745: ('<vmId> <devicespec>', Line 1746: 'Update a VM\'s device', Line 1747: 'devicespec parameters list: r=required, ' Line 1748: 'o=optional', -- To view, visit http://gerrit.ovirt.org/9561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
