Dan Kenigsberg has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. ......................................................................
Patch Set 10: Looks good to me, approved (1 inline comment) .................................................... File vdsm_cli/vdsClient.py Line 1750: 'devicespec parameters list: r=required, ' Line 1751: 'o=optional', Line 1752: 'r devicetype: interface', Line 1753: 'o network: network name - No chage if not ' Line 1754: 'specified. Dummy bridge and link inactive if ' too bad pep8 wants this indentation.. Line 1755: 'empty string', Line 1756: 'o linkActive: bool - No change if not ' Line 1757: 'specified', Line 1758: 'r alias: libvirt\'s vnic alias', -- To view, visit http://gerrit.ovirt.org/9561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
