Igor Lvovsky has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. ......................................................................
Patch Set 8: Looks good to me, approved (1 inline comment) .................................................... File vdsm_cli/vdsClient.py Line 206: return self.ExecAndExit(self.s.create(params)) Line 207: Line 208: def vmUpdateDevice(self, args): Line 209: return self.ExecAndExit(self.s.vmUpdateDevice(args[0], Line 210: self._eqSplit(args[1:]))) Yes, it's good. More of that I think we'll need to change other functions (hotpug/hotunplug Nic/Disk) to use self._eqSplit Line 211: Line 212: def hotplugNic(self, args): Line 213: nic = self._parseDriveSpec(args[1]) Line 214: nic['type'] = 'interface' -- To view, visit http://gerrit.ovirt.org/9561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
