Mark Wu has posted comments on this change. Change subject: Don't fail silently when ifup fails. ......................................................................
Patch Set 7: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/configNetwork.py Line 70: Line 71: if rc != 0: Line 72: # In /etc/sysconfig/network-scripts/ifup* the last line usually Line 73: # contains the error reason. Line 74: raise ConfigNetworkError(ne.ERR_FAILED_IFUP, out[-1]) If my understanding is correct, the check still can't change the result returned to engine for the case of dhcp. So I think it doesn't resolve the problem thoroughly. Line 75: elif toCall is not None: Line 76: toCall() Line 77: return rc, out, err Line 78: -- To view, visit http://gerrit.ovirt.org/8415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
