Dan Kenigsberg has posted comments on this change. Change subject: Don't fail silently when ifup fails. ......................................................................
Patch Set 9: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/configNetwork.py Line 1013: ifup(iface, vlanBootproto == 'dhcp' and not blockingDhcp, Line 1014: libvirtNetworkCreation) Line 1015: Line 1016: if bridged: Line 1017: ifup(network, bridgeBootproto == 'dhcp' and not blockingDhcp, oh, I've missed this fact. sorry. I knew that the async flow is too confusing. Please postpone it to another patch - if to be ever solved. Line 1018: libvirtNetworkCreation) Line 1019: Line 1020: # add libvirt network Line 1021: if not async: -- To view, visit http://gerrit.ovirt.org/8415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
