Dan Kenigsberg has posted comments on this change.
Change subject: Don't fail silently when ifup fails.
......................................................................
Patch Set 10: Looks good to me, approved
(1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 911:
Line 912: # Validation
Line 913: if not utils.tobool(force):
Line 914: logging.debug('validating network...')
Line 915: _addNetworkValidation(
these kind of fixes serves mainly as a distraction to me. I prefer special
cleanup-only patches such as http://gerrit.ovirt.org/9729
Line 916: _netinfo, network=network, vlan=vlan, bonding=bonding,
nics=nics,
Line 917: ipaddr=ipaddr, netmask=netmask, gateway=gateway,
Line 918: bondingOptions=bondingOptions, bridged=bridged, **options)
Line 919:
--
To view, visit http://gerrit.ovirt.org/8415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
