Shu Ming has posted comments on this change. Change subject: Distinguish between local and mounted SD's. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/localFsSD.py Line 106: # TODO: This function should be removed when the mangled mangling name scheme Line 107: # of mounted (nfs, Posix) SD's and local SD's is fixed but... Line 108: # Is better to remove completely the localFS SD's concept, but... Line 109: # this will not fixed by now Line 110: def isLocalFsDomain(sdUUID): Why should we bother to create a new function instead of using os.path.ismount() to check if the path composed from sdUUID is a mounted path? Line 111: """This ancillary function differentiates local and mounted SD's. Line 112: Line 113: Assumed that a local SD can't be mounted. Line 114: mounted: nfs, posixFS -- To view, visit http://gerrit.ovirt.org/10024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12b5ba80121b8e8d23a63ecc7aaab829bfc67a51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
