Shu Ming has posted comments on this change. Change subject: Distinguish between local and mounted SD's. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/localFsSD.py Line 102: def getRealPath(self): Line 103: return os.readlink(self.mountpoint) Line 104: Line 105: Line 106: def isLocalFsDomain(domainPath): I don't think we need a new function here. The exsiting os.path.ismount() can be used to replace this function. Line 107: """This ancillary function differentiates local and mounted SD's. Line 108: Line 109: Assumed that a local SD can't be mounted. Line 110: mounted: nfs, posixFS -- To view, visit http://gerrit.ovirt.org/10024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12b5ba80121b8e8d23a63ecc7aaab829bfc67a51 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
