Eduardo has posted comments on this change.
Change subject: Distinguish between local and mounted SD's.
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/localFsSD.py
Line 113: mtab = open("/etc/mtab", "r").readlines()
Line 114: for mEntry in mtab:
Line 115: if mEntry.split()[1] in domainPath:
Line 116: # This is a mounted domain therefore not exists as a
local SD.
Line 117: isLocal = False
IMHO is better to have only one exit point of the function.
Line 118: break
Line 119: else:
Line 120: isLocal = True
Line 121: return isLocal
--
To view, visit http://gerrit.ovirt.org/10024
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12b5ba80121b8e8d23a63ecc7aaab829bfc67a51
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
