Dan Kenigsberg has posted comments on this change.
Change subject: Integrate Smartcard support
......................................................................
Patch Set 17: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2425: 'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint',
Line 2426: '*smpThreadsPerCore': 'uint', 'status': 'VmStatus',
Line 2427: 'timeOffset': 'uint', 'transparentHugePages': 'bool',
Line 2428: 'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType',
Line 2429: 'smartcard': 'bool'}}
please update the schema to reflect the newly suggested api.
Line 2430:
Line 2431: ##
Line 2432: # @VmParameters:
Line 2433: #
....................................................
File vdsm_cli/vdsClient.py
Line 1720: 'o soundDevice : emulated sound device',
Line 1721: 'o launchPaused : If "true", start qemu
paused',
Line 1722: 'o vmName : human-readable name of new VM',
Line 1723: 'o tabletEnable : If "true", enable tablet
input',
Line 1724: 'o smartcard : If "true", enable
smartcard',
please update.
Line 1725: 'o timeOffset : guest\'s start date,
relative to '
Line 1726: 'host\'s time, in seconds',
Line 1727: 'o smp : number of vcpus',
Line 1728: 'o smpCoresPerSocket, smpThreadsPerCore :
vcpu '
....................................................
File vdsm/libvirtvm.py
Line 1193: </smartcard>
Line 1194: """
Line 1195: card = self.createXmlElem(self.device, None, ['address'])
Line 1196: card.setAttribute('mode', self.specParams['mode'])
Line 1197: card.setAttribute('type', self.specParams['type'])
...and if we do want to support tcp, we could add a "source" sub dictionary.
Line 1198: return card
Line 1199:
Line 1200:
Line 1201: class RedirDevice(LibvirtVmDevice):
Line 2654: if dev['device'] == vm.SMARTCARD_DEVICES and \
Line 2655: not dev.get('address'):
Line 2656: dev['address'] = address
Line 2657: dev['alias'] = alias
Line 2658:
Tomas? (I have no idea, but I would guess any device has an alias)
Line 2659: def _getUnderlyingWatchdogDeviceInfo(self):
Line 2660: """
Line 2661: Obtain watchdog device info from libvirt.
Line 2662: """
--
To view, visit http://gerrit.ovirt.org/8450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
