Tomas Jelinek has posted comments on this change.
Change subject: Integrate Smartcard support
......................................................................
Patch Set 17: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 2654: if dev['device'] == vm.SMARTCARD_DEVICES and \
Line 2655: not dev.get('address'):
Line 2656: dev['address'] = address
Line 2657: dev['alias'] = alias
Line 2658:
actually it seems that the engine does not expect the device to have an alias.
So if the alias is not defined in libvirt, VDSM don't need to define it as well
Line 2659: def _getUnderlyingWatchdogDeviceInfo(self):
Line 2660: """
Line 2661: Obtain watchdog device info from libvirt.
Line 2662: """
--
To view, visit http://gerrit.ovirt.org/8450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
