Adam Litke has posted comments on this change.
Change subject: Integrate Smartcard support
......................................................................
Patch Set 19: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2361: # Properties of a VM smartcard device.
Line 2362: #
Line 2363: # @deviceType: The device type (always @smartcard)
Line 2364: #
Line 2365: # @deviceId: A unique ID for this device
What is this? Other devices seem to use 'alias'.
Line 2366: #
Line 2367: # Since: 4.10.0
Line 2368: ##
Line 2369: {'type': 'VmSmartcardDevice',
Line 2362: #
Line 2363: # @deviceType: The device type (always @smartcard)
Line 2364: #
Line 2365: # @deviceId: A unique ID for this device
Line 2366: #
This definition is incomplete. You are missing at least 'address' and
'specParams'. Take a look at the other device definitions and make sure you
add everything that is required.
Line 2367: # Since: 4.10.0
Line 2368: ##
Line 2369: {'type': 'VmSmartcardDevice',
Line 2370: 'data': {'deviceType': 'VmDeviceType', 'deviceId': 'UUID'}}
--
To view, visit http://gerrit.ovirt.org/8450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
