Zhou Zheng Sheng has posted comments on this change. Change subject: Starting svdsm on startup ......................................................................
Patch Set 1: (2 inline comments) .................................................... Commit Message Line 9: When prepareForShutdown is invoked vdsm restarts itself, when this Line 10: haapens super vdsm supposed also to restart itself after the old instance dies. Line 11: Apparently, this happens too fast, and until the old instance dies, vdsm Line 12: tries to communicate with it and fails, and only then svdsm initiates the new Line 13: instance. Can you explain more of this problem? From supervdsm.py ProxyCaller.__call__(), I can see if vdsm calls the old super vdsm instance, it gets AuthenticationError, and kills the old super vdsm then starts a new one. Why this behaviour is not acceptable? Line 14: This patch initiates svdsm during vdsm startup instead of during the first Line 15: proxy call. Line 16: Line 17: Change-Id: Iebee1b4fbb62f3760609d12d694f466dc9379fca .................................................... File vdsm/supervdsm.py Line 148: self._cleanOldFiles() Line 149: self._authkey = None Line 150: self._manager = None Line 151: self._svdsm = None Line 152: self._firstRun = True Why rename firstLaunch to firstRun? Is it related to this patch? Line 153: Line 154: def isRunning(self): Line 155: try: Line 156: with open(self.pidfile, "r") as f: -- To view, visit http://gerrit.ovirt.org/9691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebee1b4fbb62f3760609d12d694f466dc9379fca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
