Ayal Baron has posted comments on this change. Change subject: Starting svdsm on startup ......................................................................
Patch Set 2: (1 inline comment) .................................................... File tests/superVdsmTests.py Line 65: Line 66: def testIsSuperUp(self): Line 67: self.assertTrue(self._proxy.isRunning()) Line 68: Line 69: @MonkeyPatch(supervdsm.SuperVdsmProxy, '_start', monkeyStart) why didn't you remove the decorator here? Line 70: def testKillSuper(self): Line 71: self._proxy.kill() Line 72: self.assertFalse(self._proxy.isRunning()) Line 73: self._proxy.ping() # Launching vdsm after kill -- To view, visit http://gerrit.ovirt.org/9691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebee1b4fbb62f3760609d12d694f466dc9379fca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
