Yaniv Bronhaim has posted comments on this change. Change subject: Starting svdsm on startup ......................................................................
Patch Set 2: Yes, I Know, I meant that if old svdsm instance still in the air without being controlled by vdsm, it means we still hasn't cleaned svdsm.pid file, so when we get to isRunning method, we open the file, read the pid, check the timestamp, and walla: pid still alive and its CTime is equal to what was written in svdsm timestamp file - That's why vdsm thinks it can move on and call _svdsm, and then the NameError is raised as you mentioned .. So, Kill() and then Launch() will do the work here :) -- To view, visit http://gerrit.ovirt.org/9691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebee1b4fbb62f3760609d12d694f466dc9379fca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
