Deepak C Shetty has posted comments on this change.
Change subject: tests: add iscsi storage functional test
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
def prepare is un-necessarity repeated in derived class.
....................................................
File tests/functional/xmlrpcTests.py
Line 523: connections = self._createBackend(backendDef['backends'],
rollback)
Line 524: self._connectBackend(
Line 525: connections, backendDef['timeout'], rollback)
Line 526: return self._genTypeSpecificArgs(backendDef['backends'],
rollback)
Line 527:
def prepare(....) is already present in BackendServer super class, why do we
need it in the IscsiServer class again ? Sorry i didn't see this in the prev
patch, my bad.
Line 528:
Line 529: storageLayouts = \
Line 530: {'localfs':
Line 531: {'server': LocalFSServer,
--
To view, visit http://gerrit.ovirt.org/9842
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaef5d6145b8f493b5eaab0b75564f88a4cb82ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
