Zhou Zheng Sheng has posted comments on this change.
Change subject: tests: add iscsi storage functional test
......................................................................
Patch Set 7: (2 inline comments)
Thanks Deepak!
....................................................
File tests/functional/xmlrpcTests.py
Line 505: raise RuntimeError(
Line 506: 'Can not find related device of iqn %s' % iqn)
Line 507: return iqnDevs
Line 508:
Line 509: def _genTypeSpecificArgs(self, backends, rollback):
Thanks for the suggestions. I think it should be enough for the sub-class to
override the _createBackend() and _ genTypeSpecificArgs(). However for iSCSI,
the VG name is not in the "connections" 's schema of the
storageServer_ConnectionRefs_acquire(). In BackendServer.prepare(), the
"connections" returned from the _createBackend() is passed directly to
_connectBackend() then directly to storageServer_ConnectionRefs_acquire().
That's why I did not put the VG names in "connections".
Line 510: iqns = map(lambda conn: conn['iqn'],
Line 511: backends.itervalues())
Line 512: iqnDevs = self._getIqnDevs(iqns)
Line 513:
Line 523: connections = self._createBackend(backendDef['backends'],
rollback)
Line 524: self._connectBackend(
Line 525: connections, backendDef['timeout'], rollback)
Line 526: return self._genTypeSpecificArgs(backendDef['backends'],
rollback)
Line 527:
Done
Line 528:
Line 529: storageLayouts = \
Line 530: {'localfs':
Line 531: {'server': LocalFSServer,
--
To view, visit http://gerrit.ovirt.org/9842
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaef5d6145b8f493b5eaab0b75564f88a4cb82ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
