Deepak C Shetty has posted comments on this change. Change subject: tests: add iscsi storage functional test ......................................................................
Patch Set 7: (1 inline comment) There seems to some mismatch with the _genTypeSpecificArgs argument types between base and derived class which IIUC was not intended when the BackendServer design was thought of ? .................................................... File tests/functional/xmlrpcTests.py Line 505: raise RuntimeError( Line 506: 'Can not find related device of iqn %s' % iqn) Line 507: return iqnDevs Line 508: Line 509: def _genTypeSpecificArgs(self, backends, rollback): The 'backends' arg should be replaced with 'connections'. IIUC the idea was to have _createBackend return connections object using information from the backend (storage layout) and _genTypeSpecificArgs should use the connections returned by createBackend to generate the typespecificarg. It should not refer to backend at all, createBackend is the one that should refer to and use backend info. For ur iscsi case, u should modify createBackend return the vgName (taken from the backend) in the connections dict and have _genTypeSpecificArgs use connections only. If you do that, then there is no need to override 'prepare' function in IscsiServer class, and i believe that was the intention , since prepare is already implemented in BackendServer and it quite generic enuf. Line 510: iqns = map(lambda conn: conn['iqn'], Line 511: backends.itervalues()) Line 512: iqnDevs = self._getIqnDevs(iqns) Line 513: -- To view, visit http://gerrit.ovirt.org/9842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaef5d6145b8f493b5eaab0b75564f88a4cb82ce Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
