Yaniv Bronhaim has posted comments on this change. Change subject: Starting svdsm on startup ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/supervdsm.py Line 98: # uses. We need to be able to change these variables so that running Line 99: # tests doesn't disturb and already running VDSM on the host. Line 100: self.setIPCPaths(PIDFILE, TIMESTAMP, ADDRESS) Line 101: self.kill() Line 102: self.launch() After http://gerrit.ovirt.org/#/c/10491/ I'm pretty sure that we don't need to start svdsm on startup. the above fix was the reason for startup faults.. we can start svdsm on startup and it won't hurt, but it's not a must.. I need another review opinion to accept that or i'll abandon this change. Line 103: Line 104: def setIPCPaths(self, pidfile, timestamp, address): Line 105: self.pidfile = pidfile Line 106: self.timestamp = timestamp -- To view, visit http://gerrit.ovirt.org/9691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebee1b4fbb62f3760609d12d694f466dc9379fca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
