Igor Lvovsky has posted comments on this change. Change subject: Simplify netinfo get. ......................................................................
Patch Set 9: (1 inline comment) .................................................... Commit Message Line 9: This patch refactors netinfo to have the network data fetching on Line 10: a separate function. This reduces the get() complexity and will Line 11: allow the possibility of reusing the new method for more fine- Line 12: grained information retrieval, e.g., update just a network info Line 13: of a Netinfo instance. Hmmm, if your new function is not public anymore, you not really can to use it outside of get(), but if will you will wrap it ... Line 14: Line 15: Change-Id: I5c3e617d10308d0bfa4deaed329b2e10ef54077c -- To view, visit http://gerrit.ovirt.org/11080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c3e617d10308d0bfa4deaed329b2e10ef54077c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
