Igor Lvovsky has posted comments on this change.
Change subject: Simplify netinfo get.
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
(1 inline comment)
Toni, please verify it carefully
....................................................
File vdsm/netinfo.py
Line 282: if bridged:
Line 283: data.update({'ports': ports(iface), 'stp':
bridge_stp_state(iface),
Line 284: 'cfg': getIfaceCfg(iface)})
Line 285: else:
Line 286: # ovirt-engine-3.1 expects to see the "interface"
attribute iff the
s/iff/if
Line 287: # network is bridgeless. Please remove the attribute and
this
Line 288: # comment when the version is no longer supported.
Line 289: data['interface'] = iface
Line 290: data.update({'iface': iface, 'bridged': bridged,
--
To view, visit http://gerrit.ovirt.org/11080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c3e617d10308d0bfa4deaed329b2e10ef54077c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
