Mark Wu has posted comments on this change.
Change subject: Simplify netinfo get.
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
(2 inline comments)
Just minor logging messages issue inline.
....................................................
File vdsm/netinfo.py
Line 292: 'gateway': routes.get(iface, '0.0.0.0'),
Line 293: 'mtu': getMtu(iface)})
Line 294: except OSError as e:
Line 295: if e.errno == errno.ENOENT:
Line 296: logging.info('Obtaining info for net %s.', iface,
exc_info=True)
'interface' could be more accurate than 'net' here.
Line 297: raise KeyError('Network %s was not found' % iface)
Line 298: else:
Line 299: raise
Line 300: return data
Line 293: 'mtu': getMtu(iface)})
Line 294: except OSError as e:
Line 295: if e.errno == errno.ENOENT:
Line 296: logging.info('Obtaining info for net %s.', iface,
exc_info=True)
Line 297: raise KeyError('Network %s was not found' % iface)
The same problem for 'Network'.
Line 298: else:
Line 299: raise
Line 300: return data
Line 301:
--
To view, visit http://gerrit.ovirt.org/11080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c3e617d10308d0bfa4deaed329b2e10ef54077c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
