Shu Ming has posted comments on this change.
Change subject: Storage: Check that underlying file system supports direct IO
......................................................................
Patch Set 6: (3 inline comments)
....................................................
File vdsm/storage/fileSD.py
Line 70: # open it O_DIRECT.
Line 71: testFilePath = os.path.join(mountDir, "__DIRECT_IO_TEST__")
Line 72: oop.getProcessPool(sdUUID).directTouch(testFilePath)
Line 73: except OSError as e:
Line 74: if e.errno == errno.EINVAL:
Fine with that.
Line 75: log = logging.getLogger("Storage.fileSD")
Line 76: log.error("Underlying file system doesn't support"
Line 77: "direct IO")
Line 78: raise se.StorageDomainTargetUnsupported()
....................................................
File vdsm/storage/localFsSD.py
Line 36: if os.path.abspath(typeSpecificArg) != typeSpecificArg:
Line 37: raise se.StorageDomainIllegalRemotePath(typeSpecificArg)
Line 38:
Line 39: fileSD.validateDirAccess(domPath)
Line 40: fileSD.validateFileSystemFeatures(sdUUID, domPath)
If the file system doesn't support O_DIERCT, should we allow the
FileStorageDomain instantiation continue without O_RIRECT support?
Line 41:
Line 42: sd.validateDomainVersion(version)
Line 43:
Line 44: # Make sure there are no remnants of other domain
....................................................
File vdsm/storage/nfsSD.py
Line 45: if not mount.isMounted(domPath):
Line 46: raise se.StorageDomainFSNotMounted(domPath)
Line 47:
Line 48: fileSD.validateDirAccess(domPath)
Line 49: fileSD.validateFileSystemFeatures(sdUUID, domPath)
If the file system doesn't support O_DIERCT, should we allow the
FileStorageDomain instantiation continue without O_RIRE
Line 50:
Line 51: # Make sure there are no remnants of other domain
Line 52: mdpat = os.path.join(domPath, "*", sd.DOMAIN_META_DATA)
Line 53: if len(oop.getProcessPool(sdUUID).glob.glob(mdpat)) > 0:
--
To view, visit http://gerrit.ovirt.org/9749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: humble devassy <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
