Shu Ming has posted comments on this change. Change subject: Storage: Check that underlying file system supports direct IO ......................................................................
Patch Set 6: No score (1 inline comment) .................................................... File vdsm/storage/nfsSD.py Line 45: if not mount.isMounted(domPath): Line 46: raise se.StorageDomainFSNotMounted(domPath) Line 47: Line 48: fileSD.validateDirAccess(domPath) Line 49: fileSD.validateFileSystemFeatures(sdUUID, domPath) If the file system doesn't support O_DIERCT, should we allow the FileStorageDomain instantiation continue without O_DIRECT support? Line 50: Line 51: # Make sure there are no remnants of other domain Line 52: mdpat = os.path.join(domPath, "*", sd.DOMAIN_META_DATA) Line 53: if len(oop.getProcessPool(sdUUID).glob.glob(mdpat)) > 0: -- To view, visit http://gerrit.ovirt.org/9749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: humble devassy <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
