Peter V. Saveliev has posted comments on this change.
Change subject: migrateStatus() progress report
......................................................................
Patch Set 16: (3 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 428: self.data_progress = calculateProgress(dataRemaining,
dataTotal)
Line 429: self.mem_progress = calculateProgress(memRemaining,
memTotal)
Line 430:
Line 431: self._vm.log.info('Migration Progress: %s seconds
elapsed, %s%% of'
Line 432: ' data processed, %s%% of mem
processed' %
I see nothing wrong with percents in logs. What else should we log here?
Anyway, that's not my code and not the subject of the changeset.
Line 433: (timeElapsed / 1000,
Line 434: self.data_progress,
Line 435: self.mem_progress))
Line 436:
....................................................
File vdsm/vm.py
Line 121: if self._monitorThread is not None:
Line 122: # fetch migration status from the monitor thread
Line 123: self.status['progress'] = int(
Line 124: float(self._monitorThread.data_progress +
Line 125: self._monitorThread.mem_progress) / 2)
nope, the progress is updated from this thread only.
Line 126: return self.status
Line 127:
Line 128: def _setupVdsConnection(self):
Line 129: if self._mode == 'file':
Line 1201: def migrateCancel(self):
Line 1202: self._acquireCpuLockWithTimeout()
Line 1203: try:
Line 1204: self._migrationSourceThread.stop()
Line 1205: return self._migrationSourceThread.status
Done
Line 1206: except libvirt.libvirtError as e:
Line 1207: if e.get_error_code() ==
libvirt.VIR_ERR_OPERATION_INVALID:
Line 1208: return errCode['migCancelErr']
Line 1209: raise
--
To view, visit http://gerrit.ovirt.org/6824
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
