Vinzenz Feenstra has posted comments on this change.
Change subject: migrateStatus() progress report
......................................................................
Patch Set 16: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 428: self.data_progress = calculateProgress(dataRemaining,
dataTotal)
Line 429: self.mem_progress = calculateProgress(memRemaining,
memTotal)
Line 430:
Line 431: self._vm.log.info('Migration Progress: %s seconds
elapsed, %s%% of'
Line 432: ' data processed, %s%% of mem
processed' %
Peter: He means that we should not use string formatting like this, but the
pass it to logging as parameters. However as you said, it's not subject of this
patch.
Line 433: (timeElapsed / 1000,
Line 434: self.data_progress,
Line 435: self.mem_progress))
Line 436:
--
To view, visit http://gerrit.ovirt.org/6824
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
