Michal Skrivanek has posted comments on this change. Change subject: migrateStatus() progress report ......................................................................
Patch Set 17: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/vm.py Line 1202: self._acquireCpuLockWithTimeout() Line 1203: try: Line 1204: self._migrationSourceThread.stop() Line 1205: self._migrationSourceThread.status['status']['message'] = \ Line 1206: 'Migration process canceled' well, we just made it "tunneling" instead of "tunnelling", following the US spelling seems to make sense Line 1207: return self._migrationSourceThread.status Line 1208: except libvirt.libvirtError as e: Line 1209: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 1210: return errCode['migCancelErr'] -- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
