Antoni Segura Puimedon has posted comments on this change. Change subject: Don't crash on libvirt network re-definition. ......................................................................
Patch Set 6: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 408: with open(file_path, 'r') as conf_file: Line 409: for line in conf_file: Line 410: if line.startswith('BRIDGE=' + network): Line 411: port = file_path[file_path.rindex('-') + 1:] Line 412: logging.debug('port %s found in ifcfg for %s', port, We're only using it right now when a network has been broken, so I think it is useful to have some extra info about this kind of case. Line 413: network) Line 414: ports.append(port) Line 415: return ports Line 416: -- To view, visit http://gerrit.ovirt.org/10901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d95e20b7aa99280e604abdb1663c6c5c7dd32e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches