Antoni Segura Puimedon has posted comments on this change.
Change subject: Don't crash on libvirt network re-definition.
......................................................................
Patch Set 7: (1 inline comment)
Thanks for the review Mark.
....................................................
File vdsm/configNetwork.py
Line 411: port = filePath[filePath.rindex('-') + 1:]
Line 412: logging.debug('port %s found in ifcfg for
%s', port,
Line 413: network)
Line 414: ports.append(port)
Line 415: break
@Mark: I don't break the outer loop for information purposes. In case of a more
broken, it can give me/the admin good info about what is
going on.
Line 416: return ports
Line 417:
Line 418: def writeConfFile(self, fileName, configuration):
Line 419: '''Backs up the previous contents of the file referenced by
fileName
--
To view, visit http://gerrit.ovirt.org/10901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d95e20b7aa99280e604abdb1663c6c5c7dd32e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
