Dan Kenigsberg has submitted this change and it was merged. Change subject: Don't crash on libvirt network re-definition. ......................................................................
Don't crash on libvirt network re-definition. This patch is aimed to solve the libvirt syncing bug described in bugurl. In short, the vdsmd restart scenario is solved by the previous patch (30c63c5). This one solves the case when the interface backing a bridge/network has disappeared (and thus is not reported by netinfo to the engine) and then the engine sends a new setupnetwork that attempts to recreate the partially defined network. Up until now, libvirt would report an exception. Now we make a best-effort to remove the network before trying to add it again, by adding a control case in the setupNetworks logic where networks to be removed are usually removed. Bug-Url: https://bugzilla.redhat.com/861701 Change-Id: I76d95e20b7aa99280e604abdb1663c6c5c7dd32e Signed-off-by: Antoni S. Puimedon <[email protected]> --- M vdsm/configNetwork.py 1 file changed, 50 insertions(+), 6 deletions(-) Approvals: oVirt Jenkins CI Server: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76d95e20b7aa99280e604abdb1663c6c5c7dd32e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
