Dan Kenigsberg has uploaded a new change for review. Change subject: Do not attempt to run hook with an unknown vnic ......................................................................
Do not attempt to run hook with an unknown vnic If hotunplugNic() is called with a badly-specified vnic, we should not run the after_nic_hotunplug_fail() hook, as we cannot supply its required param: nicXml is unassigned at this stage. Change-Id: I0e4f1d8e0b7f83324edd903f9204bb05fdd19626 Bug-Url: https://bugzilla.redhat.com/919356 Signed-off-by: Dan Kenigsberg <[email protected]> --- M vdsm/libvirtvm.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/12891/1 diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py index 93a36f2..39d1b5b 100644 --- a/vdsm/libvirtvm.py +++ b/vdsm/libvirtvm.py @@ -1684,7 +1684,6 @@ else: self.log.error("Hotunplug NIC failed - NIC not found: %s", nicParams) - hooks.after_nic_hotunplug_fail(nicXml, self.conf) return {'status': {'code': errCode['hotunplugNic'] ['status']['code'], 'message': "NIC not found"}} -- To view, visit http://gerrit.ovirt.org/12891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0e4f1d8e0b7f83324edd903f9204bb05fdd19626 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
