Dan Kenigsberg has posted comments on this change. Change subject: Do not attempt to run hook with an unknown vnic ......................................................................
Patch Set 1: Assaf, the removed hook point has NEVER run, as you can see in the logs of https://bugzilla.redhat.com/show_bug.cgi?id=919356#c0 . So there is no change in behavior in this regard. Calling a function with a bogus nicxml sounds worse than not calling it at all. -- To view, visit http://gerrit.ovirt.org/12891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e4f1d8e0b7f83324edd903f9204bb05fdd19626 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Itzik Brown <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
