Assaf Muller has posted comments on this change. Change subject: Do not attempt to run hook with an unknown vnic ......................................................................
Patch Set 1: I would prefer that you didn't submit this Our clients might be surprised if they use an after_nic_hotunplug hook and it won't be run. Imagine a client sending wrong VNIC parameters to the hot unplug command, and the command failing without his hook being ran. Does it make any sense to run the hook with a VNIC that doesn't actually exist? If so, a proposed solution would be to add another version of before_nic_hotunplug that accepts a NIC's parameters and generates a minimal XML defintion for that NIC, and then forwards the call to the original version of the method. -- To view, visit http://gerrit.ovirt.org/12891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e4f1d8e0b7f83324edd903f9204bb05fdd19626 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Itzik Brown <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
